The 'show interfaces' command has seen a number of changes and additions over time, and it could be helpful to reevaluate where the implementation current stands in an attempt to simplify and streamline the solution.
Description
Description
Details
Details
- Version
- -
- Is it a breaking change?
- Unspecified (possibly destroys the router)
- Issue type
- Unspecified (please specify)
Event Timeline
Comment Actions
A quick flyby review shows the number of lines of code could be reduced by quite a bit. This isn't conclusive for a direction one way or the other. Just informational. Less code does not necessarily equal better:
Associated functions:
Legacy solution (show interfaces): Total lines 450
show() show_summary() show_summary_extended() show_counters() _show_raw() _format_show_counters() _format_show_summary_extended() _format_show_summary() _format_show_data() _get_counter_data() _get_summary_data() _get_raw_data() _format_stats() _find_intf_by_ifname() _pppoe() _get_counter_val() _split_text() filtered_interfaces()
New solution (show interfaces kernel):Total lines 162
show_kernel() _get_kernel_data() _format_kernel_data()