Page MenuHomeVyOS Platform
Create Task
Maniphest T8038

xml: cleanup double CLI properties in NAT
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

We can remove the XML <properties> because it's the same as already defined in #include <include/nat-rule.xml.i>

diff --git i/interface-definitions/nat.xml.in w/interface-definitions/nat.xml.in
index 73a748137..93dd847d6 100644
--- i/interface-definitions/nat.xml.in
+++ w/interface-definitions/nat.xml.in
@@ -65,17 +65,6 @@
         <children>
           #include <include/nat-rule.xml.i>
           <tagNode name="rule">
-            <properties>
-              <help>Rule number for NAT</help>
-              <valueHelp>
-                <format>u32:1-999999</format>
-                <description>Number of NAT rule</description>
-              </valueHelp>
-              <constraint>
-                <validator name="numeric" argument="--range 1-999999"/>
-              </constraint>
-              <constraintErrorMessage>NAT rule number must be between 1 and 999999</constraintErrorMessage>
-            </properties>
             <children>
               #include <include/firewall/outbound-interface.xml.i>
               <node name="translation">

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects

Event Timeline

c-po created this task.Tue, Nov 25, 3:29 PM
c-po changed the task status from Open to In progress.
c-po claimed this task.
c-po triaged this task as Low priority.
c-po added a comment.Tue, Nov 25, 3:34 PM

https://github.com/vyos/vyos-1x/pull/4870

pasik subscribed.Tue, Nov 25, 3:55 PM
c-po added a project: VyOS 1.4 Sagitta (1.4.4).Thu, Nov 27, 7:19 AM
c-po mentioned this in rVYOSONEXfb29b82569e6: nat: T8038: remove duplicate XML definitions for <properties>.Thu, Nov 27, 8:19 AM
Restricted Repository Identity mentioned this in rVYOSONEX81eb7510621b: Merge pull request #4870 from c-po/xml-nat-cleanup.Thu, Nov 27, 8:19 AM
c-po closed this task as Resolved.Thu, Nov 27, 3:01 PM
c-po moved this task from Need Triage to Completed on the VyOS Rolling board.
c-po moved this task from Backlog to Finished on the VyOS 1.4 Sagitta (1.4.4) board.
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.Mon, Dec 8, 7:36 PM
dmbaturin changed Issue type from Feature (new functionality) to Internal change (not visible to end users).